Add integer check for alphabet size#2458
Open
heapframe wants to merge 4 commits into
Open
Conversation
Fixes "Generate De Bruijn Sequence - RangeError in blob:null/6895a5cc-cf19-4023-b300-36e358dad354 on line 2.<br><br>Message: invalid array length"
|
|
Comment on lines
+53
to
+56
| if (!Number.isInteger(k)) { | ||
| throw new OperationError("Invalid alphabet size, required to be integer."); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Need a similar test / error for n not being an integer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "
Generate De Bruijn Sequence - RangeError in blob:null/6895a5cc-cf19-4023-b300-36e358dad354 on line 2.<br><br>Message: invalid array length"Description
Adds a check for "Alphabet Size" to make sure its an integer and not a float
Existing Issue
#2450
AI disclosure
I did not use any AI tools.
Test Coverage
Before:
After: